Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Ensure Image Name Reflects in ImagesOutputWindow During Build/Pull #7561

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Fix: Ensure Image Name Reflects in ImagesOutputWindow During Build/Pull #7561

merged 4 commits into from
Oct 1, 2024

Conversation

VikalpRusia
Copy link
Contributor

@VikalpRusia VikalpRusia commented Sep 28, 2024 •
edited
Loading

Bug

Image Name is not getting reflected in the ImagesOutputWindow, while building/pulling image

Why?

imageToPull variable was uninitialised

More details

#7559

Changes

  • Added imageToPull in props and modified places where ImagesOutputWindow.vue was being called

Screenshots

Build

Screenshot 2024-09-28 at 10 46 44 PM

Pull

Screenshot 2024-09-28 at 10 47 43 PM

closes #7559

@VikalpRusia
Added image name in build error
b650a63 
Signed-off-by: Vikalp Rusia <vikalprusia@gmail.com>
@VikalpRusia
Added image name in scan
d068a57 
Signed-off-by: Vikalp Rusia <vikalprusia@gmail.com>
@VikalpRusia
Default mode modified
c6b3995 
Signed-off-by: Vikalp Rusia <vikalprusia@gmail.com>
@VikalpRusia
run eslint --fix
139600a 
Signed-off-by: Vikalp Rusia <vikalprusia@gmail.com>
@gunamata gunamata requested a review from mook-as October 1, 2024 16:49
mook-as
mook-as approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling it imageToPull everywhere is kind of odd when we're fixing errors when building images, but 🤷

pkg/rancher-desktop/pages/images/add.vue Show resolved Hide resolved
@mook-as mook-as merged commit b25d842 into rancher-sandbox:main Oct 1, 2024
17 checks passed
@VikalpRusia VikalpRusia deleted the improve-readablity branch October 1, 2024 18:32
@VikalpRusia VikalpRusia mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mook-as mook-as mook-as approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing image name during error while building image
2 participants
@VikalpRusia @mook-as