Bump to Lima 1.0.0-beta.0 #7666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nino-K
reviewed
Oct 22, 2024
scripts/dependencies/lima.ts
Outdated
| if (platform === 'darwin') { | ||
| platform = 'macos-11.amd64'; | ||
| platform = 'macos-13.amd64'; |
There was a problem hiding this comment.
Optional, would it make sense to go in a variable?
There was a problem hiding this comment.
Not sure what should go into a variable. I've turned the 4 lines into a single line with expression interpolations, but that's all I can think off.
The hard-coded macos-13 is a bit annoying, but I don't know how we can parameterize it; it depends on a GitHub Action workflow in a different repo...
| @@ -36,24 +32,10 @@ func SetupLimaHome(appHome string) error { | |||
| if !stat.Mode().IsDir() { | |||
| return fmt.Errorf("path %q exists but isn't a directory", candidatePath) | |||
| } | |||
| os.Setenv("LIMA_HOME", candidatePath) | |||
| _ = os.Setenv("LIMA_HOME", candidatePath) | |||
| return nil | |||
There was a problem hiding this comment.
We should just return os.Setenv("LIMA_HOME", candidatePath).
Get rid of `limactl.ventura`, we are going to use the macOS-13 binaries everywhere. Testing by the Lima project itself indicates that releases build on latest XCode still work on older macOS versions. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois
force-pushed
the
bump-lime-1.0.0.rd0
branch
from
2a15be5
to
e6db46d
Compare
Nino-K
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of
limactl.ventura, we are going to use the macOS-13 binaries everywhere. Testing by the Lima project itself indicates that releases build on latest XCode still work on older macOS versions.Fixes #7463
Closes #7669