Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include patch link in rawResource response #128

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Conversation

crobby
Copy link
Contributor

@crobby crobby commented Jan 16, 2025

Required for issue: rancher/rancher#40712
Related Steve PR: rancher/steve#450

@crobby crobby requested a review from a team as a code owner January 16, 2025 10:49
@crobby crobby requested a review from ericpromislow January 16, 2025 14:25
Copy link

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. I'm assuming this is the correct thing to do.

@crobby crobby requested a review from a team January 16, 2025 23:57
@prachidamle prachidamle requested review from joshmeranda and removed request for a team February 5, 2025 22:50
Copy link

@joshmeranda joshmeranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crobby crobby merged commit 4b61aa1 into rancher:main Feb 11, 2025
1 check passed
crobby added a commit to crobby/apiserver that referenced this pull request Feb 12, 2025
* Add patch as a verb

* Update test to mock CanPatch

* Update watcher_test to mock CanPatch

* Regen fakes/mock_server_types

* Add basic test for addLinks function
crobby added a commit that referenced this pull request Feb 14, 2025
* Add patch as a verb

* Update test to mock CanPatch

* Update watcher_test to mock CanPatch

* Regen fakes/mock_server_types

* Add basic test for addLinks function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants