checking for null pointer

rancher · Oct 1, 2019 · 436e55d · 436e55d
1 parent f4d4d33
commit 436e55d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/...logic/src/main/java/io/cattle/platform/iaas/api/filter/secret/SecretValidationFilter.java b/...logic/src/main/java/io/cattle/platform/iaas/api/filter/secret/SecretValidationFilter.java
@@ -14,7 +14,11 @@ public class SecretValidationFilter extends AbstractDefaultResourceManagerFilter
     @Override
     public Object create(String type, ApiRequest request, ResourceManager next) {
         Secret s = request.proxyRequestObject(Secret.class);
-        if (!Base64.isBase64(s.getValue())) {
+        String secretValue = s.getValue();
+        if (secretValue == null) {
+            throw new ValidationErrorException("EmptySecret", "value", "Secret cannot be empty");
+        }
+        if (!Base64.isBase64(secretValue)) {
             throw new ValidationErrorException("InvalidBase64", "value", "Invalid base64 content");
 
         };