This repository was archived by the owner on Jan 4, 2022. It is now read-only.
Compose: don't export null values #636
Merged
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove requestedHostId/cpuSet from rancher-compose (used to keep there as docker-compose doesn't support these params, but never read them). We can re-enable cpuSet, but to put it to the docker-compose.yml once docker-compose starts support it
|
LGTM. Wondering whether we should do a StringUtils.isEmpty() check or is null sufficient |
|
@sonchang I'll keep it in mind as a future improvement. |
ibuildthecloud
added a commit
that referenced
this pull request
Jun 18, 2015
Compose: don't export null values
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as docker-compose doesn't support these params, but never read them). We can re-enable cpuSet, but to put it to the docker-compose.yml once docker-compose starts supporting it (docker-compose.yml should support every docker run option docker/compose#754)