Slsa charts bypass #153
Merged
Slsa charts bypass #153
+185
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tashima42
reviewed
Nov 14, 2024
pkg/regsync/generateconfig.go
Outdated
|
|
||
| file, err := os.Open(path.SlsaYamlFile) | ||
| if err != nil { | ||
| return nil, nil // backward version compatibility |
pjbgf
requested changes
Nov 14, 2024
pkg/path/path.go
Outdated
| @@ -50,12 +63,15 @@ const ( | |||
| // RepositoryLogosDir is a directory on your Staging/Live branch that contains the files with the logos of each chart | |||
| RepositoryLogosDir = "assets/logos" | |||
|
|
|||
| // RepositoryStAte file is a file to hold the current status of the released and developed assets versions | |||
| // RepositoryStateFile file is a file to hold the current status of the released and developed assets versions | |||
There was a problem hiding this comment.
Suggested change
| // RepositoryStateFile file is a file to hold the current status of the released and developed assets versions | |
| // RepositoryStateFile is a file to hold the current status of the released and developed assets versions |
pkg/regsync/generateconfig.go
Outdated
|
|
||
| file, err := os.Open(path.SlsaYamlFile) | ||
| if err != nil { | ||
| return nil, nil // backward version compatibility |
There was a problem hiding this comment.
Suggested change
| return nil, nil // backward version compatibility | |
| return nil, err // backward version compatibility |
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short:
Charts that have images supporting SLSA must no longer be synced from:
docker hub -> primer registry.
Solution
On the charts repository, there will be a new file called
slsa.yaml; see: rancher/charts#4760The chart owners will update this file with the new slsa compliant images.
We bypass the
regsync processfor the prime registry for all these images.