Update external URLs if cattle values are provided #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiyengar2
force-pushed
the
update_external_urls
branch
2 times, most recently
from
04e7707
to
650e08c
Compare
aiyengar2
commented
Apr 7, 2021
| externalUrl: "{{ tpl .Values.alertmanager.alertmanagerSpec.externalUrl . }}" | ||
| {{- else if and .Values.alertmanager.ingress.enabled .Values.alertmanager.ingress.hosts }} | ||
| externalUrl: "http://{{ tpl (index .Values.alertmanager.ingress.hosts 0) . }}{{ .Values.alertmanager.alertmanagerSpec.routePrefix }}" | ||
| +{{- else if not (or (kindIs "invalid" .Values.global.cattle.url) (kindIs "invalid" .Values.global.cattle.clusterId)) }} |
There was a problem hiding this comment.
kindIs "invalid" {field} is a nice little hack that allows us to not have to check .Values.global and .Values.global.cattle before looking at this field. If .Values.global or .Values.global.cattle do not exist, these statements will return true (since it is invalid). It will also return true if they are empty strings.
Credit goes to Masterminds/sprig#53 (comment).
aiyengar2
force-pushed
the
update_external_urls
branch
from
650e08c
to
c839bd8
Compare
prachidamle
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the externalURL to the rancher proxy if and only if
.Values.global.cattle.urland.Values.global.cattle.clusterIdare set.While these will be set magically by default in Rancher 2.5.8 onwards by the dashboard UI, this solution doesn't prevent a user from manually setting these fields to be able to use this in Rancher 2.5.7 or before.