Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.10] UnRc webhook/v0.6.2 #4891

Merged
merged 2 commits into from
Dec 18, 2024
Merged

[v2.10] UnRc webhook/v0.6.2 #4891

merged 2 commits into from
Dec 18, 2024

Conversation

gehrkefc
Copy link
Contributor

No description provided.

@gehrkefc gehrkefc requested a review from a team as a code owner December 18, 2024 20:32
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@prachidamle
Copy link
Member

LGTM.

nit for future : Note its better to split the commits into following steps :

  • actual chart file changes
  • make charts
  • make remove

@gehrkefc gehrkefc merged commit 255fee5 into rancher:dev-v2.10 Dec 18, 2024
4 checks passed
@nflynt nflynt mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflynt nflynt nflynt approved these changes

@prachidamle prachidamle prachidamle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gehrkefc @prachidamle @nflynt