unable to modify istio-sidecar-injector configmap from helm values

[skanakal]

Issue:

SURE-9607

Problem

unable to modify istio-sidecar-injector configmap from helm values

Solution

Testing

Engineering Testing

Manual Testing

root@master-0:~# helm get values -n istio-system rancher-istio
USER-SUPPLIED VALUES:
cni:
  enabled: true
global:
  cattle:
    clusterId: local
    clusterName: local
    rkePathPrefix: ""
    rkeWindowsPathPrefix: ""
    systemDefaultRegistry: registry.rancher.com
    systemProjectId: p-xgf9h
    url: https://master-0.com
  **logAsJson: true
  logging:
    level: default:info**
  systemDefaultRegistry: registry.rancher.com
ingressGateways:
  enabled: false
tracing:
  enabled: true
root@master-0:~# 
root@master-0:~# kubectl get pod -n istio-system
NAME                                     READY   STATUS    RESTARTS   AGE
istio-cni-node-9dzvz                     1/1     Running   0          11m
istiod-6f45d4f8fc-m9rqm                  1/1     Running   0          11m
kiali-5bfb6f7c8b-hjnpb                   1/1     Running   0          62s
rancher-istio-tracing-747c8468bf-hwdsz   1/1     Running   0          11m
root@master-0:~# 
root@master-0:~# kubectl logs -n istio-system istiod-6f45d4f8fc-m9rqm 
{"level":"info","time":"2025-01-13T21:19:43.959148Z","msg":"FLAG: --caCertFile=\"\""}
{"level":"info","time":"2025-01-13T21:19:43.959180Z","msg":"FLAG: --clusterAliases=\"[]\""}
{"level":"info","time":"2025-01-13T21:19:43.959183Z","msg":"FLAG: --clusterID=\"Kubernetes\""}
{"level":"info","time":"2025-01-13T21:19:43.959186Z","msg":"FLAG: --clusterRegistriesNamespace=\"istio-system\""}
{"level":"info","time":"2025-01-13T21:19:43.959188Z","msg":"FLAG: --cniNamespace=\"istio-system\""}
{"level":"info","time":"2025-01-13T21:19:43.959191Z","msg":"FLAG: --configDir=\"\""}
{"level":"info","time":"2025-01-13T21:19:43.959193Z","msg":"FLAG: --ctrlz_address=\"localhost\""}
{"level":"info","time":"2025-01-13T21:19:43.959197Z","msg":"FLAG: --ctrlz_port=\"9876\""}
{"level":"info","time":"2025-01-13T21:19:43.959200Z","msg":"FLAG: --domain=\"cluster.local\""}
{"level":"info","time":"2025-01-13T21:19:43.959202Z","msg":"FLAG: --grpcAddr=\":15010\""}
{"level":"info","time":"2025-01-13T21:19:43.959206Z","msg":"FLAG: --help=\"false\""}
{"level":"info","time":"2025-01-13T21:19:43.959208Z","msg":"FLAG: --httpAddr=\":8080\""}
{"level":"info","time":"2025-01-13T21:19:43.959211Z","msg":"FLAG: --httpsAddr=\":15017\""}
{"level":"info","time":"2025-01-13T21:19:43.959214Z","msg":"FLAG: --keepaliveInterval=\"30s\""}
{"level":"info","time":"2025-01-13T21:19:43.959217Z","msg":"FLAG: --keepaliveMaxServerConnectionAge=\"30m0s\""}
{"level":"info","time":"2025-01-13T21:19:43.959219Z","msg":"FLAG: --keepaliveTimeout=\"10s\""}
{"level":"info","time":"2025-01-13T21:19:43.959222Z","msg":"FLAG: --kubeconfig=\"\""}
{"level":"info","time":"2025-01-13T21:19:43.959225Z","msg":"FLAG: --kubernetesApiBurst=\"160\""}
{"level":"info","time":"2025-01-13T21:19:43.959229Z","msg":"FLAG: --kubernetesApiQPS=\"80\""}
**{"level":"info","time":"2025-01-13T21:19:43.959232Z","msg":"FLAG: --log_as_json=\"true\""}**

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

[github-actions]

Validation steps

• Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  

• Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
• Approve the PR to run the CI check.

[diogoasouza]

Hi @skanakal, could you please organize this in commits containing:
1st - Changes to /packages folder
2st - Changes from make charts and changes to index.yaml and release.yaml

[github-actions]

Validation steps

• Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  

• Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
• Approve the PR to run the CI check.

[github-actions]

Validation steps

• Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  

• Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
• Approve the PR to run the CI check.

[skanakal]

Hi @skanakal, could you please organize this in commits containing: 1st - Changes to /packages folder 2st - Changes from make charts and changes to index.yaml and release.yaml

@diogoasouza I’ve organized the changes as suggested.