Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove app, catalog, multiclusterapp commands #405

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

rohitsakala
Copy link
Member

@rohitsakala rohitsakala commented Nov 26, 2024

Ref: rancher/rancher#48252

Rancher PR rancher/rancher#47661
Inspired by #403

Summary

  • MCA, Project Apps and Catalogv1 are deprecated long back. So removing the corresponding commands for Rancher v2.11.

@rohitsakala rohitsakala requested a review from a team as a code owner November 26, 2024 17:43
Copy link
Contributor

@pmatseykanets pmatseykanets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but requires go mod tidy

JonCrowther
JonCrowther previously approved these changes Nov 26, 2024
pmatseykanets
pmatseykanets previously approved these changes Nov 26, 2024
@rohitsakala rohitsakala dismissed stale reviews from pmatseykanets and JonCrowther via ce7492c December 3, 2024 17:45
@rohitsakala rohitsakala force-pushed the removal-of-catalog-v1 branch from a943890 to ce7492c Compare December 3, 2024 17:45
@pmatseykanets pmatseykanets changed the title Remove catalogv1, project app and MCA Remove app, catalog, multiclusterapp commands Dec 3, 2024
@pmatseykanets pmatseykanets merged commit 0b6ae1f into rancher:main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants