Add error handling to extension load (#13204)

* Add error handling to extension load * Fix formatting following rebase
rancher · Jan 31, 2025 · 56fbea3 · 56fbea3
1 parent 478e195
commit 56fbea3
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/shell/core/plugins.js b/shell/core/plugins.js
@@ -92,7 +92,7 @@ export default function(context, inject, vueApp) {
           element.dataset.purpose = 'extension';
 
           element.onload = () => {
-            if (!window[id]) {
+            if (!window[id] || (typeof window[id].default !== 'function')) {
               return reject(new Error('Could not load plugin code'));
             }
 
@@ -106,7 +106,13 @@ export default function(context, inject, vueApp) {
             plugins[id] = plugin;
 
             // Initialize the plugin
-            window[id].default(plugin, this.internal());
+            try {
+              window[id].default(plugin, this.internal());
+            } catch (e) {
+              delete plugins[id];
+
+              return reject(new Error('Could not initialize plugin'));
+            }
 
             // Load all of the types etc from the plugin
             this.applyPlugin(plugin);