Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding web-worker polyfill breaks sourcemap tools #12511

Closed
richard-cox opened this issue Nov 6, 2024 · 2 comments · Fixed by #12400
Closed

Embedding web-worker polyfill breaks sourcemap tools #12511

richard-cox opened this issue Nov 6, 2024 · 2 comments · Fixed by #12400
Assignees
Labels
kind/bug QA/manual-test Indicates issue requires manually testing
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Nov 6, 2024

Setup

  • Rancher version: 2.9

Describe the bug
The BLOB code from web-worker is minified, and contains source maps that are then passed over by webpack - that creates a situation of minified code inside BLOB inside minified code which confuses some tools, eg.

jantimon/chrome-profile-sourcemap-resolver#4

That could be fixed, but the only reason to do so would be supporting very old (pre-2013) browsers, so we are better off removing the polyfill altogether.

Expected Result
Validation steps for QA

  • Browser Tab 1 - Open Pods list and create a trivial pod
  • Browser Tab 1 - Open browsers dev tools window --> Network tab --> WS tab --> socket connection for the cluster --> MEssages tab
  • Browser Tab 2 - Nav to edit page for pod and edit it
  • Browser Tab 1 - See resoure.change message for pod just changed

Notes
Fallback brought in when fixing another issue - #6563

@richard-cox richard-cox added kind/bug QA/manual-test Indicates issue requires manually testing labels Nov 6, 2024
@richard-cox richard-cox added this to the v2.11.0 milestone Nov 6, 2024
@richard-cox
Copy link
Member Author

/backport v2.10.1

@richard-cox
Copy link
Member Author

/backport v2.9.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/manual-test Indicates issue requires manually testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants