Add in web-worker again, fix chrome in -head builds
#6563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline worker bits to avoid CORS issues in chrome when dashboard is `-head`
mantis-toboggan-md
approved these changes
Aug 3, 2022
This was referenced Nov 5, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root issue was caused by the worker being served from our CDN on a different domain from that of the dashboard. This is not an issue when running dev locally or when the build is not
-head(as the worker and dashboard would come from the same domain).This PR first reverts (first commit) the revert of #6553, thus adding back in the changes from #6421. It then fixes the root issue (second commit) by inline bundling the workers.
I've tested this by pushing to my rancher/dashboard richard-cox-dev branch.