Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up on improving Fleet performance #12895

Closed
aruiz14 opened this issue Dec 17, 2024 · 1 comment
Closed

Follow-up on improving Fleet performance #12895

aruiz14 opened this issue Dec 17, 2024 · 1 comment
Assignees
@aruiz14 @richard-cox @IsaSih
Labels
area/fleet area/performance kind/bug QA/manual-test Indicates issue requires manually testing
Milestone
v2.11.0

Comments

@aruiz14
Copy link
Contributor

aruiz14 commented Dec 17, 2024

Follow-up of #12424, where a few areas of improvement were identified but was mainly focused on the resources table, which suffered the biggest slowdown.

Setup

  • Rancher version: 2.9 - 2.10

Describe the bug
See original issue for details.

Additional context
Areas of improvement:

  • Continuous Delivery dashboard iterates over all bundles and clusters multiple times per repository (for calculating the badge, tooltip, etc.)
    • This information is already available in the GitRepo resource status
  • While resourcesStatuses was improved as part of the original issue, clusterResourceStatus is still inefficient.
    • Many of it usages use find to pick only one cluster. We need to review and address them.
  • Cluster details pages iterate over all clusters, to later filter by the one being displayed, which is not ideal.
@aruiz14 aruiz14 added kind/bug area/fleet area/performance QA/manual-test Indicates issue requires manually testing labels Dec 17, 2024
@aruiz14 aruiz14 added this to the v2.11.0 milestone Dec 17, 2024
@aruiz14 aruiz14 mentioned this issue Dec 17, 2024
Merged
7 tasks
@IsaSih IsaSih self-assigned this Jan 29, 2025
@aruiz14 aruiz14 mentioned this issue Jan 30, 2025
Closed
@IsaSih
Copy link
Contributor

IsaSih commented Feb 14, 2025

Satisfactory performance. Validated in
Rancher | v2.11-3d729db8a848fb2523bbc2f3f21aa5367dcdcc69-head
Dashboard | master df18acc
Rancher CLI | v2.11.0-rc.1

@IsaSih IsaSih closed this as completed Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aruiz14 aruiz14

@richard-cox richard-cox

@IsaSih IsaSih

Labels
area/fleet area/performance kind/bug QA/manual-test Indicates issue requires manually testing
Projects
None yet
Milestone
v2.11.0
Development

No branches or pull requests
3 participants
@aruiz14 @richard-cox @IsaSih