-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Fleet performance #12896
base: master
Are you sure you want to change the base?
Improve Fleet performance #12896
Conversation
1783856
to
47662d6
Compare
@aruiz14 i had to re-run all jobs given the build job output had expired, this has brought in an issue in check-i18n-links that should be fixed with a rebase |
c6c3951
to
8479f60
Compare
@aruiz14 I found a difference in status colors between main and your branch. However, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments about Dashboard -> Status columns.
Preprocessing counts for every gitrepo to avoid recalculating every time
8479f60
to
b351a7e
Compare
Summary
Issue #12895
Performance improvements while keeping the same behavior.
Occurred changes and/or fixed issues
(Changes are logically split into different commits)
clusterID
vs. "clusterLabel" (which normally refers to the management Cluster resource name, while the Fleet Cluster name is usually the same as the "display" name).clusterId
is compound by${namespace}/${name}
of theCluster
resource, making it easier to work with.management
"Cluster" object (clusterLabel
) is only really needed for calculating thedetailLocation
of deployed resouces, as they will link to the Explorer, which uses the management clusters' names.clusterResourceStatus
, which is always combined with afind
byclusterLabel
(nowclusterId
).Technical notes summary
Above changes were driven by capturing and analyzing Performance traces with the Chrome Dev Tools, on a local Rancher installation where many sample workloads were installed.
See a summary of CPU usage over 30s of loading the CD dashboard:
Areas or cases that should be tested
Areas which could experience regressions
These changes aim for improving performance while not introducing any changes to the information being displayed.
I've performed several tests using a local UI build and couldn't find any difference, but I may have missed something.
Checklist