[2.6.7] Remove RKE1 Windows provisioning due to EOL #5995
Assignees
Labels
area/rke
area/windows
Windows
ember
Ember UI Issue
JIRA
kind/enhancement
priority/0
QA/XS
release-note
size/0.5
Size Estimate 0.5
team/area2
Hostbusters
Milestone
Comments
|
@gaktive Would we be able to setup a meeting to work with a dedicated UI resource to investigate and document what we need to do for the RKE1 Windows EOL? |
|
@rosskirkpat let me see who could help out here and I'll find some time next week. cc @nwmac |
|
Internal reference: SURE-4703 |
codyrancher
added
[zube]: Backend Blocked
size/0.5
codyrancher
added a commit
to codyrancher/ui
that referenced
this issue
Jun 7, 2022
|
I created two separate PRs depending on whether we're going to remove windows support vs showing a deprecation banner. |
catherineluse
changed the title
|
Tested on v2.6.7-rc6: however, this message only shows up during creation of a new cluster. We should enhance the message to also show up for rke1 clusters on the provisioning page at a minimum, so that the user sees the message when trying to register the windows node in rke1. i.e. on this page, but only for rke1 clusters. |
|
@slickwarren We already have it in two places. Why is this new third place critical? |
|
That screenshot is from ember. Currently the provisioning/registration page in 2.6.7 does not have a warning ( 2nd screenshot from my previous comment) |
|
tested on v2.6.7-rc9: |
bisht-richa
pushed a commit
to bisht-richa/dashboard
that referenced
this issue
Aug 12, 2022
bisht-richa
added a commit
that referenced
this issue
Aug 22, 2022
* Modifed sidebar, docusaurus.config and custom css * Added sub directories * Changes section name and fixed link error * Fixed Getting Started and Components & Design kit svg size * Added baseUrl dashboard * Update Cypress to version 10 (#6146) * Run Cypress migration scripts; Update failing parts * Move env var assignments to Cypress configuration; Correct env patterns * Correct imports within the Cypress tests * Correct TS linting configuration errors after update * Return directly spec path in cypress configuration * Change global token setting name * Minor improvement to cluster dashboard page for alerts tab (#6536) * HARVESTER: Fix namespace filter wrong on Harvester page (#6523) * Fix workspace filtering - This was broken by #6261 - The `activeNamespaceCache` depends on the product (fleet requires workspaces, everything else namespaces) - This needs updating when going to or from fleet NOTE - On `head` (but not `ui-dashboard-index` `latest`) refreshing on the explorer pods page does not show the correct namespace filtered pods Small tidyup for `activeNamespaceCache` and `activeNamespaceFilters` getters * Take NS filter into account when updating SortableTable's `arrangedRows` inside ResourceTables * Use web worker to throttle counts and schema changes (#6421) * Use web worker to throttle counts and schema changes * Delete nodes.md * Address PR feedback * Small tidy up * Fix dependencies for plugins * Address PR feedback * Fix lint issue * Improve presentation of add Member dialog (#6500) * Improve presentation of add Member dialog * Updated for PR feedback * kubeconfig-default-ttl-minutes setting takes numeric input only * Selected webhook type is persisted in UI * HARVESTER: fix image clone miss label * HARVESTER: validate image displayName * HARVESTER: prevent submit * HARVESTER: delete displayName RFC1123 validations * Adds form-validation back in after deployments redesign * Revert "Use web worker to throttle counts and schema changes (#6421)" This reverts commit 4687fbc. * Script to create standalone build for testing * Remove debug * Add missing socket * Tweaks and fixes - Remove unused mimeTypes (and eslint file) - add some build output dirs to gitignore - fix serve of html files (content was in ui/dist instead of ui) * Create unit test and linting jobs with GitHub Actions (#6562) * Add GitHub Actions on push to run lint and unit test * Store unit test coverage as artifact * Correct unit tests coverage path collection * Add i18n linting on CI * Correct rancher-component path * Remove pull request trigger from Drone * Fix linting from master Co-authored-by: Richard Cox <richard.cox@suse.com> * Fix live and delayed columns not updating * Fix activeNamespaceCache given change in master * Handle changes in sort field or order - also created convenience method watcherUpdateLiveAndDelayed * fix azure warning banner link * do not assume ec2 vpc obj have Tags * When adding alerting rule, provide a default namespace label * Revert "Merge pull request #6553 from mantis-toboggan-md/revert-6421" This reverts commit c86abfa, reversing changes made to 57f9a37. * Fix web worker Inline worker bits to avoid CORS issues in chrome when dashboard is `-head` * fix issue when on first login we were setting an empty value to state.workspace because user doesnt have an prefs set (#6586) Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan> * Incremental loading and manual refresh features (#6543) - Add manual refresh experimental feature to specific list views - Add incremental loading experimental feature to specific list views Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan> Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local> Co-authored-by: Richard Cox <richard.cox@suse.com> * Group up GHA config under test; Remove push cases (#6587) * Temporarily disable FOSSA * Fix disabled drone build * Namespace filters apply on first page load * Refactor namespace caching and filtering * Fix build * Fix flicking between fleet workspaces with equal resources - fleet workspace switch toggles straight between 2 selections - this results in the case that the row count doesn't change - the `activeNamespaceCacheKey` cache is used to cover this case - this was broken given in original pr and after my suggested edit * fix-issue-multiple-resource-counts-on-resource-fetch-mixin (#6589) Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan> * Remove unneeded API call to get projects from local cluster * Harvester: fix override when saving multiple VMs * Harvester: Fix reserved memory edit issue * HARVESTER: fix template OSType not automatically filled * Harvester: typology field is inputable if get nodes failed * Harvester: move harvester specific code out of PodAffinity * default podaffinity namespaces prop to null instead of empty array * Added ranche fav icon, removed not used images * Tweaks to the performance settings & loading indicator - Following UX review this is the first set of changes - The text on the settings page has been improved - The background of the incremental loader has been removed - Fixed a typo (`UI_PERFORNMANCE`) * E2E: Create dashboard access for reviewing tests results (#6576) * Add sorry-cypress library, commands and configuration * Replace e2e test run ID to be used for the dashboard with title, id and number run * Add missing instruction for the dashboard * Set default browser to Chrome * Updated env template * do not attempt to filter-by-namespace for unnamespaced harvester resources * Reset user preferences on E2E start or requests (#6535) * Add user preference command for Cypress stubs * Include global types to Cypres TS configuration * Prevent distributed interface issues on lint * Improve initial load of Home and Cluster Dashboard pages Home Page - Don't block whole page on loading of mgmt and prov clusters - Use table `loading` indicator when clusters are loading - Use correct cluster count (with harv cluster filter) - To confirm Cluster Dashboard - EventsTable - use standard table loading indicator - Don't block on fetch at all (or show page loading indicator) - Remove fetch for nodeTemplates and rke1NodePools. I went through a lot of code and don't think these are needed - Reminaing calls for Node and Metrics can happen at the same time - Forget additional resource types when leaving page - Optimise fetch of management nodes Pre-Page optimisations - Authentication Mixin - if applicable, fetch `principal` 'me' same time as `user` 'me' Other tweaks - Don't show AwsComplianceBanner or AzureWarning until management store ready * Revert changes to authentication - previously combined request for user and principal together, instead of making them sequentially - this should have been safe (both calls will fail or succeed given auth state)... - ... might not be given ways requests are handled (i chickened out) * Address PR feedback - Split calls to `setPromiseResult` into multiple lines - Ensure label is correctly used (drop duplicate text) - Improve beforeDestroy comment - Add JSDoc to setPromiseResult * Use getters instead of `setPromiseResult` for known resource types * Create `diagnostic` page (#6603) * Adds diagnostic page, accessible via the about page Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local> Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan> Co-authored-by: Richard Cox <richard.cox@suse.com> * For certain roles hide concept of namespace outside of groups Users who have no overaching view of the cluster (non-rancher admins, non-cluster owners) - shouldn't see namespaces outside of their projects - shouldn't be able to create namespaces outside of their projects (specifically not in a project) * Fix namespace detail page when a namespace filter is applied - Caused by `filteredRows` running causing `getActiveNamespaces` to run.. which in tern triggers other table's `filteredRows`, etc - Fix is to only update `activeNamespaceCache` if there were actual changes - Tested - ns detail page - project/namespaces list - fleet resources - fleet resources where there are only 1 entry in two workspaces * Fix resource counts in side nav - This looks like it was a regression from https://github.com/rancher/dashboard/pull/6570/files#diff-87b5f0108669b304fbe8fa4b9684ffb07e42c4c41320580a8768e6ab4edf23ddL72 - It worked at the time on my rancher (b8afb4e - 20th July). Bug appears on later versions. Not sure why - `activeNamespaceCache` should be pretty safe now we only update it given genuine changes * save harvester kubeconfig as secret * add ownerref to harvester kubeconfig secret * do not set ownerref on kube secret; add annotation * add additional harvester kube secret annotation * initial content for 2.6.7 (#6449) * initial content for 2.6.7 Signed-off-by: Gary A Korhonen <gkorhonen@suse.com> Fixes #6430 Includes 2.6.6 blurb though there was only one bug addressed * revised AWS blurb * fixed typo in AWS bit * Update shell/content/docs/en-us/whats-new.md Signed-off-by: Gary A Korhonen <gkorhonen@suse.com> Co-authored-by: Sergey Nasovich <85187633+snasovich@users.noreply.github.com> * Update shell/content/docs/en-us/whats-new.md Signed-off-by: Gary A Korhonen <gkorhonen@suse.com> Co-authored-by: Sergey Nasovich <85187633+snasovich@users.noreply.github.com> * Update shell/content/docs/en-us/whats-new.md Signed-off-by: Gary A Korhonen <gkorhonen@suse.com> Co-authored-by: Sergey Nasovich <85187633+snasovich@users.noreply.github.com> * added MSAL copy & fixed some wording * updated 2.6.6 section * updated amazon billing Co-authored-by: Sergey Nasovich <85187633+snasovich@users.noreply.github.com> * force user to delete all ns in project if they cant see ns outside of projects rm unused class * Pull request template has question about browser * reworded 1.24 blurb for 2.6.7 (#6621) Signed-off-by: Gary A Korhonen <gkorhonen@suse.com> * Harvester: remove Pod Scheduling on harvester cluster page * Adding a windows deprecation banner to the registration command of rke1 clusters #5995 (comment) * Fix package script and visibility of incremental loading indicator Script Changes - fixed `require` errors - ensure dashboard ignores output of scripts (useful for local dev) Dashboard Changes - only show the resource loading indicator if incremental loading is enabled * Modifed sidebar, docusaurus.config and custom css * Added sub directories * Removed not used images * Added docusaurus in tsconfig. * Updated baseUrl * Formatting update * Ensure local cluster kube node's can determine their cluster id - We determine the cluster id via the node's `self` link - Normally this is something like `k8s/clusters/c-m-274kcrc4/v1/nodes/nodeid` However for the local cluster this is only v1/nodes/nodeid` - This meant that for local cluster nodes it's norman and mgmt nodes were unavailable - From what i can this only affected it's ability to - determine it's role (though this had a working fallback) - determine if some actions were shown (and also execute them) * Fix plugins * Re-enable FOSSA check * Fixed lint error Signed-off-by: Gary A Korhonen <gkorhonen@suse.com> Co-authored-by: Giuseppe Leo <giuseppe.leo@suse.com> Co-authored-by: Catherine Luse <catherine.luse@gmail.com> Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com> Co-authored-by: Qingyang Nong <n313893254@126.com> Co-authored-by: Richard Cox <richard.cox@suse.com> Co-authored-by: wujun <897415845@qq.com> Co-authored-by: Sean <sean.mchugh@suse.com> Co-authored-by: Nancy <42977925+mantis-toboggan-md@users.noreply.github.com> Co-authored-by: Neil MacDougall <nmacdougall@suse.com> Co-authored-by: Alexandre Alves <97888974+aalves08@users.noreply.github.com> Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan> Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local> Co-authored-by: yuzeng <cridequeger@yahoo.com> Co-authored-by: Richard Cox <ricox@suse.com> Co-authored-by: Gary A Korhonen <gkorhonen@suse.com> Co-authored-by: Sergey Nasovich <85187633+snasovich@users.noreply.github.com> Co-authored-by: Cody Jackson <cody.jackson@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rancher/windows#179
rancher/windows#182
As part of the 2.6.6 release, RKE1 Windows will be EOL. We need to remove the ability to provision new RKE1 Windows clusters through the Rancher UI.
In the UI, this will mean the removal of the Windows Support boolean during the RKE1 provisioning and any other functionality specific to Windows.
The text was updated successfully, but these errors were encountered: