Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual refresh feature to "heavy" list views #6498

Closed
aalves08 opened this issue Jul 26, 2022 · 4 comments
Closed

Add manual refresh feature to "heavy" list views #6498

aalves08 opened this issue Jul 26, 2022 · 4 comments
Assignees
Milestone

Comments

@aalves08
Copy link
Member

Some list views for resources are quite "heavy" in terms of usage for mem and CPU, so we want to provide an option to the user (on global settings) where they can enable the ability to manual refresh a list, preventing therefore the watch on the resource that triggers constant UI updates and slows down rancher dashboard and is detrimental to the user experience.

@catherineluse
Copy link
Contributor

Related issue #6484

@git-ival
Copy link

git-ival commented Aug 11, 2022

@aalves08 @bmdepesa @catherineluse
Tested all suggested cases from PR #6543 using Rancher 2.6.7-rc9. LGTM except for the case where Manual Refresh + Incremental Loading are enabled and the list view is paginated (See the middle/end of the last video below).

Essentially, when both features are enabled and you navigate to the 2nd page and you perform a Manual Refresh then the list view fails to load any entries.

Note: The issue identified above could be constrained to only occur on the final page since I only had 2 pages to work with.

No Manual Refresh + No Incremental Loading:

Rancher-2.6.7-rc9-NoManual-NoIncremental.mp4

Manual Refresh:

Rancher-2.6.7-rc9-ManualRefresh.mp4

Incremental Loading:

Rancher-2.6.7-rc9-IncrementalLoading.mp4

Manual Refresh + Incremental Loading:

Rancher-2.6.7-rc9-ManualRefresh-IncrementalLoading.mp4

@aalves08
Copy link
Member Author

aalves08 commented Aug 12, 2022

@git-ival I've merged a fix for the pagination issue. 🙏

FYI @gaktive

@git-ival
Copy link

git-ival commented Aug 12, 2022

@aalves08 @bmdepesa @catherineluse
Tested all suggested cases from PR #6543 using Rancher 2.6-head (ee084d0).

LGTM, however can you confirm the expected behavior when Manual Refresh and Incremental Loading are enabled when there are multiple pages on the list view @aalves08?
Observed Behavior: Post-fix when I was on the last page of a list view with multiple pages of results, I manually refreshed and it reloaded the entire list which sent me back to the first page. You can see the final video below for context.

EDIT: LGTM. Discussed with rancher/ui team members and this is the expected behavior

No Manual Refresh + No Incremental Loading:

Rancher-2.6head-NoManual-NoIncremental.mp4

Manual Refresh:

Rancher-2.6head-ManualRefresh.mp4

Incremental Loading:

Rancher-2.6head-IncrementalLoading.mp4

Manual Refresh + Incremental Loading:

Rancher-2.6head-ManualRefresh-IncrementalLoading.mp4

Behavior of Manual Refresh + Incremental Loading with Multi-Page list view:

Rancher-2.6head-ManualRefresh-IncrementalLoading-MultiPageBehavior.mp4

@zube zube bot removed the [zube]: To Test label Aug 12, 2022
@zube zube bot added the [zube]: Done label Aug 12, 2022
@zube zube bot removed the [zube]: Done label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants