Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Add support for incremental data loading #6540

Closed
nwmac opened this issue Jul 28, 2022 · 3 comments · Fixed by #6543
Closed

Performance: Add support for incremental data loading #6540

nwmac opened this issue Jul 28, 2022 · 3 comments · Fixed by #6543

Comments

@nwmac
Copy link
Member

nwmac commented Jul 28, 2022

Currently when we load resources, we load all data into the client before displaying data.

We should fetch data incrementally, so that users can start to use resource lists while the full data loads.

@gaktive
Copy link
Member

gaktive commented Aug 2, 2022

Looks like #6543 is the new PR tied here.

@git-ival
Copy link

git-ival commented Aug 11, 2022

@nwmac @bmdepesa
Tested all suggested cases from PR #6543 using Rancher 2.6.7-rc9. LGTM except for the case where Manual Refresh + Incremental Loading are enabled and the list view is paginated.

Essentially, when both features are enabled and you navigate to the 2nd page and you perform a Manual Refresh then the list view fails to load any entries.

Note: The issue identified above could be constrained to only occur on the final page since I only had 2 pages to work with.

See videos attached on my comment on issue #6498 for context.

@git-ival
Copy link

Closing with latest retest of #6498 using 2.6-head (ee084d0). See my comment for details.

@zube zube bot removed the [zube]: Done label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment