Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure harvester cloud creds with expiration date of 0 are sorted correctly #12351

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Oct 24, 2024

Summary

Ensure harvester cloud creds with expiration date of 0 are sorted correctly

Occurred changes and/or fixed issues

Areas or cases that should be tested

  • Harvester Cloud Credential page with an expired annotation value of 0 appear immediately after / before (depending on sort order) expiring and then expired tokens
    • I hacked get expires() for an easier production

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

- sort order should be expired --> expiring --> never expires
- ensure expired 0 is not in the same bucket as never expires
@richard-cox
Copy link
Member Author

Once this merges harvester/harvesterhci.io#72 should come out of draft

Copy link
Member

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit d5024a1 into rancher:master Oct 25, 2024
34 checks passed
@richard-cox richard-cox deleted the fix-expires-sort-rder branch October 25, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants