Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.10] Use BundleDeployment status to calculate GitRepo resources #12520

Merged

Conversation

aruiz14
Copy link
Contributor

@aruiz14 aruiz14 commented Nov 6, 2024

Summary

Fixes #12516
Fixes #12578
Forward-port of #12443

@aruiz14 aruiz14 requested review from richard-cox and moio and removed request for richard-cox November 6, 2024 15:30
@aruiz14 aruiz14 changed the base branch from master to release-2.10 November 6, 2024 15:31
@aruiz14 aruiz14 requested a review from richard-cox November 6, 2024 15:33
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.10.1 milestone Nov 6, 2024
Copy link
Contributor

@moio moio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch contents are effectively identical to #12443, LGTM

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just blocked on the release of 2.10.0 and then this can merge

@aruiz14 aruiz14 force-pushed the rework-gitrepo-status-resources-2.10 branch from 990c526 to 03d7083 Compare November 20, 2024 10:38
@richard-cox
Copy link
Member

Latest change looks good, see #12630 (review) for details

@richard-cox richard-cox merged commit 674e698 into rancher:release-2.10 Nov 21, 2024
27 checks passed
@richard-cox richard-cox linked an issue Nov 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[backport v2.10.1] Re-enable CLI Download e2e tests [backport v2.10.1] Improve Fleet Performance
3 participants