Fix Node Scheduling / Node Name option in Workloads page #12962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
torchiaf
requested review from
cnotv and
a110605
and removed request for
cnotv
richard-cox
reviewed
Jan 2, 2025
| @@ -182,7 +184,8 @@ export default { | |||
| :mode="mode" | |||
| :multiple="false" | |||
| :loading="loading" | |||
| @input="update" | |||
| :data-testid="'node-scheduling-nodeSelector'" | |||
| @update:value="update" | |||
There was a problem hiding this comment.
do we have the same issue for the other 12 places @input="update" is used?
cnotv
reviewed
Jan 6, 2025
| import NodeScheduling from '@shell/components/form/NodeScheduling.vue'; | ||
| import { _CREATE, _EDIT, _VIEW } from '@shell/config/query-params'; | ||
|
|
||
| const requiredSetup = () => { |
There was a problem hiding this comment.
It's not convenient to have mocks outside the tests, but it's not a blocker.
cnotv
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12939
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist