fix keyboard nav for home page #12966
Open
+128
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalves08
force-pushed
the
12776-fix-keyboard-nav-home-page
branch
from
ae607b8 to
50c9515
Compare
22 tasks
rak-phillip
reviewed
Jan 3, 2025
pkg/rancher-components/src/components/Form/Checkbox/Checkbox.vue
Outdated
Show resolved
Hide resolved
aalves08
force-pushed
the
12776-fix-keyboard-nav-home-page
branch
from
7da65a7 to
f7a177e
Compare
rak-phillip
reviewed
Jan 6, 2025
| @@ -599,6 +611,9 @@ export default defineComponent({ | |||
| :to="createLocation" | |||
| class="btn btn-sm role-primary" | |||
| data-testid="cluster-create-button" | |||
| role="link" | |||
| :aria-label="t('generic.create')" | |||
| @keyup.space="$router.push(createLocation)" | |||
There was a problem hiding this comment.
There's quite a few links that still use space for activation. I think these can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12776
Occurred changes and/or fixed issues
homepageBannercomponent has correct roles, labels and is focusableSortableTablecomponent has been fixed for basic keyboard nav (sorting, checkboxes, links, open/close row action menu)Technical notes summary
Areas or cases that should be tested
homepage and browse the page with the tab keyenterorspacekey to trigger UI elements on the pageAreas which could experience regressions
Screenshot/Video
Screen.Recording.2025-01-02.at.16.23.48.mov
Checklist