Performance: Don't allow column definiton changes in sortable table #6389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
requested changes
Jul 19, 2022
| @@ -52,14 +52,15 @@ export default { | |||
| }, | |||
|
|
|||
| data() { | |||
| const headers = this.tableHeaders || []; | |||
There was a problem hiding this comment.
These references should stay as header. This fn is called once when the component is created and tableHeaders hasn't been initialised yet (so there's no sort order set, for instance on the workloads list)
|
Closed in favor of web worker PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small improvement to the sortable table.
On my large cluster, schema updates occur quite frequently, which causes the headers computed to re-evaluate.
This PR watches the headers and only updates a new
tableHeadersproperty when the actual set of columns changes (checks names). This means is a column definition changes while viewing a table, this will be not be reflected - but we do not expect this to happen and currently this does not happen.