Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected webhook type is persisted in UI #6532

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

catherineluse
Copy link
Contributor

This PR fixes #6526 by making it so that the webhook type is correctly persisted after a receiver of type webhook is configured. To test, I did the same steps as the steps to reproduce in the issue description. Alibaba SMS, MS Team, and Generic types should all be persisted when coming back to the config form.

@catherineluse catherineluse requested a review from Shavindra July 28, 2022 00:40
@nwmac nwmac added this to the v2.6.7 milestone Jul 28, 2022
Copy link
Contributor

@Shavindra Shavindra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@catherineluse catherineluse merged commit f976705 into rancher:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants