kubeconfig-default-ttl-minutes setting takes numeric input only #6546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catherineluse
force-pushed
the
setting-value
branch
from
75188f2 to
20b0a84
Compare
catherineluse
force-pushed
the
setting-value
branch
from
20b0a84 to
7f2570f
Compare
mantis-toboggan-md
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6530 by specifying a
kind: 'integer'for thekubeconfig-default-ttl-minutessetting.That kind was not something you could select already, so I added a numeric-only input to the setting edit page.
Note: The backend wants the number to be formatted as a string, so I cast the number to a string when adding it to the form values.
This is not the only setting that should accept numeric input only, but fixing all the numeric settings seemed like it should be outside the scope of 2.6.7, so I opened a new issue to track that here: #6547