-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HARVESTER: Fix HARVESTER v1.0.3 VM issues #6560
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
33e2c95
Harvester: fix override when saving multiple VMs
DaiYuzeng 86a0487
Harvester: Fix reserved memory edit issue
n313893254 eaf75d1
HARVESTER: fix template OSType not automatically filled
WuJun2016 542ca71
Harvester: typology field is inputable if get nodes failed
DaiYuzeng 3ad5318
Harvester: move harvester specific code out of PodAffinity
DaiYuzeng f0e16d7
default podaffinity namespaces prop to null instead of empty array
mantis-toboggan-md File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
shell/edit/kubevirt.io.virtualmachine/VirtualMachineReserved.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| <script> | ||
| import UnitInput from '@shell/components/form/UnitInput'; | ||
|
|
||
| export default { | ||
| name: 'HarvesterReserved', | ||
| components: { UnitInput }, | ||
|
|
||
| props: { | ||
| reservedMemory: { | ||
| type: String, | ||
| default: null | ||
| }, | ||
| mode: { | ||
| type: String, | ||
| default: 'create', | ||
| }, | ||
| }, | ||
|
|
||
| data() { | ||
| return { memory: this.reservedMemory }; | ||
| }, | ||
|
|
||
| watch: { | ||
| reservedMemory(memory) { | ||
| this.memory = memory; | ||
| }, | ||
| }, | ||
|
|
||
| methods: { | ||
| change() { | ||
| const { memory } = this; | ||
|
|
||
| this.$emit('updateReserved', { memory }); | ||
| }, | ||
| } | ||
| }; | ||
| </script> | ||
|
|
||
| <template> | ||
| <div class="row mb-20"> | ||
| <div class="col span-6"> | ||
| <UnitInput | ||
| v-model="memory" | ||
| v-int-number | ||
| :label="t('harvester.virtualMachine.input.reservedMemory')" | ||
| :mode="mode" | ||
| :input-exponent="2" | ||
| :increment="1024" | ||
| :output-modifier="true" | ||
| @input="change" | ||
| /> | ||
| </div> | ||
| </div> | ||
| </template> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this request need to move out of the
allHashSettledabove?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to catch the errors of node's request since the response of node may have
404/500error code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for I missed the link to the issue 2567 that the local cluster owner has no permission to access the node resource.