do not attempt to filter by namespace for any unnamespaced resource #6606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantis-toboggan-md
changed the title
mantis-toboggan-md
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6596
If this is not true, resource table filters its rows wrt the namespace filter (and calculates active namespaces to do so):
if ( (!this.isNamespaced || isAll) && !isVirtualProduct)The logic here is a little off. We don't want to attempt to filter by ns if the resource is not namespaced, regardless of whether it's a harvester resource or not. "Why does this cause an infinite loop in the project/namespace list specifically?" You may ask. Good question. I think this is because the project/namespace list component also retrieves namespaces via getter and these two calls are causing each other to re-calculate. Regardless, that
ifblock is wrong and fixing it fixes the bug.