Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tag rancher command #482

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tashima42
Copy link
Contributor

@tashima42 tashima42 commented Sep 12, 2024

  • Removes unused configs (registry related commands were removed)
  • Moves dry run and skip status check configs to flags
  • Moves logs to the cli code
  • Removes support for debug releases (they were renamed to hotfix and now the bullseye team handles it)


return nil
// GetHTMLURL will return an empty value if it isn't present
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the error check on the CreateRelease call?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because createdRelease.GetHTMLURL() returns an empty string if it isn't available, returning it and err is the same as checking err and returning an empty string

createdRelease, err := repository.CreateRelease(ctx, ghClient, opts)
if err != nil {
    return "", err
}
return createdRelease.GetHTMLURL(), nil

Is the same as

createdRelease, err := repository.CreateRelease(ctx, ghClient, opts)
return createdRelease.GetHTMLURL(), err

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants