Set the proper namespace #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are trying to get the cattle-elemental-system namespace into rancher as a system namespace, while we have a different namespace around, including in the elemental examples. This changes the wrong namespace into the proper one Signed-off-by: Itxaka <igarcia@suse.com>
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 29.16% 29.16%
=======================================
Files 5 5
Lines 360 360
=======================================
Hits 105 105
Misses 251 251
Partials 4 4 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This should probably be accompanied by (a pointer to) documentation about what the "proper" namespaces for Elemental are. 🤔 |
Well you can actually install it anywhere, but on the "official" install docs and chart defaults it should go to the one that rancher will mark as "system". I mean, you can install rancher to a different namespace, Im sure of that :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to get the cattle-elemental-system namespace into rancher
as a system namespace, while we have a different namespace around,
including in the elemental examples.
This changes the wrong namespace into the proper one
Signed-off-by: Itxaka igarcia@suse.com