Split header into 7Kb of data #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This generates several X-Cattle-Smbios-NUMER headers when sending the data to the operator in order to limit the max size of each individual header to 7Kb. By default nginx is configured with a max of 8Kb header and will return a 400 error if the headers excess that size. As we currently use a GET+Websocket to go trougth the challenge/response of TPM, this is the easiest implementation to workaround the issue. Signed-off-by: Itxaka <igarcia@suse.com>
github-actions
bot
added
area/operator
Codecov Report
@@ Coverage Diff @@
## main #133 +/- ##
==========================================
- Coverage 29.16% 28.53% -0.64%
==========================================
Files 5 5
Lines 360 368 +8
==========================================
Hits 105 105
- Misses 251 259 +8
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
As this needs -register and -operator changed, I'll tag a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates several X-Cattle-Smbios-NUMER headers when sending the
data to the operator in order to limit the max size of each individual
header to 7Kb. By default nginx is configured with a max of 8Kb header
and will return a 400 error if the headers excess that size.
As we currently use a GET+Websocket to go trougth the challenge/response
of TPM, this is the easiest implementation to workaround the issue.
Signed-off-by: Itxaka igarcia@suse.com