Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility for smbios headers #137

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Aug 12, 2022

Adds backwards compatibility for clients sending old headers with smbios
data

Signed-off-by: Itxaka igarcia@suse.com

Adds backwards compatibility for clients sending old headers with smbios
data

Signed-off-by: Itxaka <igarcia@suse.com>
@Itxaka Itxaka requested review from kkaempf, mjura and fgiudici August 12, 2022 09:01
@github-actions github-actions bot added area/operator operator related changes area/tests test related changes labels Aug 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #137 (a5f3de0) into main (be788bc) will increase coverage by 5.47%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   28.30%   33.77%   +5.47%     
==========================================
  Files           5        5              
  Lines         371      379       +8     
==========================================
+ Hits          105      128      +23     
+ Misses        262      246      -16     
- Partials        4        5       +1     
Impacted Files Coverage Δ
pkg/server/register.go 23.97% <100.00%> (+11.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Itxaka Itxaka merged commit 72971ff into rancher:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operator operator related changes area/tests test related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants