-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
machine registration connectivity rework - part II #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/operator
operator related changes
area/register
register related changes
labels
Aug 19, 2022
fgiudici
force-pushed
the
websocket_reg02
branch
from
August 23, 2022 08:21
0a2f60a
to
858e46f
Compare
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 33.77% 33.77%
=======================================
Files 5 5
Lines 379 379
=======================================
Hits 128 128
Misses 246 246
Partials 5 5 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fgiudici
force-pushed
the
websocket_reg02
branch
from
August 23, 2022 08:45
858e46f
to
a8c9328
Compare
Itxaka
reviewed
Aug 31, 2022
Itxaka
approved these changes
Aug 31, 2022
davidcassany
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
get the latest and gratest: d273b29 tpm: add single step functions to perform attestation baef878 Merge pull request #3 from fgiudici/status_in_dial_error 30058b5 Include more info in the error msg on Dial() error a02dabe Merge pull request #4 from fgiudici/lint_add_comment eab8ac2 Make the linter happy (add a comment) 89d72d3 Add EmulatedHostSeed option Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
Till now, the attestation and communication with the elemental operator were all demanded to the github.com/rancher-sandbox/go-tpm package. Split TPM attestation from the communication with the elemental operator demanding TPM authentication to the external library while taking full control of the communication with the operator. This doesn't introduce functional changes (so it will keep retrocompatibility with the current elemental operator) and is a preparatory step to address #5 Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
fgiudici
force-pushed
the
websocket_reg02
branch
from
August 31, 2022 13:33
a8c9328
to
931c6cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/build
build related changes
area/operator
operator related changes
area/register
register related changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the client-side equivalent of #140.
Note that this needs first that rancher-sandbox/go-tpm#5 got merged, then this branch will be updated with the new go-tpm version (for this reason got the(merged, blocked flag removed)blocked
flag).register: take control of the registration process
Till now, the attestation and communication with the elemental operator
were all demanded to the github.com/rancher-sandbox/go-tpm package.
Split TPM attestation from the communication with the elemental operator
demanding TPM authentication to the external library while taking full
control of the communication with the operator.
This doesn't introduce functional changes (so it will keep retrocompatibility
with the current elemental operator) and is a preparatory step to address
#5