Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine registration connectivity rework - part II #141

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Conversation

fgiudici
Copy link
Member

@fgiudici fgiudici commented Aug 19, 2022

This is the client-side equivalent of #140.
Note that this needs first that rancher-sandbox/go-tpm#5 got merged, then this branch will be updated with the new go-tpm version (for this reason got the blocked flag). (merged, blocked flag removed)

register: take control of the registration process
Till now, the attestation and communication with the elemental operator
were all demanded to the github.com/rancher-sandbox/go-tpm package.
Split TPM attestation from the communication with the elemental operator
demanding TPM authentication to the external library while taking full
control of the communication with the operator.

This doesn't introduce functional changes (so it will keep retrocompatibility
with the current elemental operator) and is a preparatory step to address
#5

@github-actions github-actions bot added area/operator operator related changes area/register register related changes labels Aug 19, 2022
@fgiudici fgiudici requested a review from a team August 19, 2022 15:53
@github-actions github-actions bot added the area/build build related changes label Aug 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #141 (858e46f) into main (f0bd8f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   33.77%   33.77%           
=======================================
  Files           5        5           
  Lines         379      379           
=======================================
  Hits          128      128           
  Misses        246      246           
  Partials        5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

get the latest and gratest:

d273b29 tpm: add single step functions to perform attestation
baef878 Merge pull request #3 from fgiudici/status_in_dial_error
30058b5 Include more info in the error msg on Dial() error
a02dabe Merge pull request #4 from fgiudici/lint_add_comment
eab8ac2 Make the linter happy (add a comment)
89d72d3 Add EmulatedHostSeed option

Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
Till now, the attestation and communication with the elemental operator
were all demanded to the github.com/rancher-sandbox/go-tpm package.
Split TPM attestation from the communication with the elemental operator
demanding TPM authentication to the external library while taking full
control of the communication with the operator.

This doesn't introduce functional changes (so it will keep retrocompatibility
with the current elemental operator) and is a preparatory step to address
#5

Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
@fgiudici fgiudici merged commit 4ce5d77 into main Aug 31, 2022
@fgiudici fgiudici deleted the websocket_reg02 branch August 31, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build build related changes area/operator operator related changes area/register register related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants