support command improvements #173
Conversation
Gathers logs for pods in some namespaces Signed-off-by: Itxaka <igarcia@suse.com>
Itxaka
force-pushed
the
extend_support
branch
from
6e66a96 to
13b275f
Compare
Reworks copyFilesInDir so it sets the same structure from teh source dir into the temp dir in case we are storing things in the wrong place. Also introduces a redacter regex to remove any instances of passwd or password in the oem files as those are the ones most probable to contain passwords as part of the cloud-config files of setting the system and we dont want to store those Signed-off-by: Itxaka <igarcia@suse.com>
Signed-off-by: Itxaka <igarcia@suse.com>
Itxaka
force-pushed
the
extend_support
branch
from
02b52c7 to
ce86f05
Compare
Codecov ReportBase: 38.15% // Head: 38.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
=======================================
Coverage 38.15% 38.15%
=======================================
Files 10 10
Lines 857 857
=======================================
Hits 327 327
Misses 505 505
Partials 25 25 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| logrus.Warnf("Failed to get %s on namespace %s: %s", resource, pod, err) | ||
| } | ||
| // We still want to write the output if the resource was not found or another issue occurred as that can shed info on what's going on | ||
| _ = os.WriteFile(fmt.Sprintf("%s/%s-%s-logs.log", dest, resource, pod), out, os.ModePerm) |
There was a problem hiding this comment.
why did you decide to suppress the error? If that is intentional then suggested change should work too
| _ = os.WriteFile(fmt.Sprintf("%s/%s-%s-logs.log", dest, resource, pod), out, os.ModePerm) | |
| os.WriteFile(fmt.Sprintf("%s/%s-%s-logs.log", dest, resource, pod), out, os.ModePerm) |
There was a problem hiding this comment.
linting prevents this. Explicitly catch return values
There was a problem hiding this comment.
supressing errors is becuase this si a best-effort-catch-all util. Do not care about errors, not want to show errors to the users, just get as much logs as possible from the system.
| func copyDir(srcdir string, destdir string) { | ||
| contents, err := os.ReadDir(srcdir) | ||
| if err != nil { | ||
| return |
There was a problem hiding this comment.
can add a log entry in case it fails?
There was a problem hiding this comment.
same as above, dont care if it fails, its not supposed to give errors to the user, just tryu to get as much info as possible otherwise you get an error spouting util on your already broken system. Bad vibes :)
support: Add k8s logs to support command
support: Rework copyFilesInDir to get full path
support: skip getting k8s resources if no kubeconfig
Signed-off-by: Itxaka igarcia@suse.com