Bump wharfie to v0.5.3

[mudler]

Fixes: #11

Signed-off-by: Ettore Di Giacinto edigiacinto@suse.com

[mudler]

Seems this is quite not possible yet, as new wharfie requires new features from go-container registry, and system-agent is stuck at https://github.com/rancher/system-agent/blob/main/go.mod#L35.

I've tried by pinning an old container-registry, but then fails on wharfie, which requires new one:

# github.com/rancher/wharfie/pkg/registries
/go/pkg/mod/github.com/rancher/wharfie@v0.5.3/pkg/registries/registries.go:141:16: undefined: remote.DefaultTransport

[rosskirkpat]

Seems this is quite not possible yet, as new wharfie requires new features from go-container registry, and system-agent is stuck at https://github.com/rancher/system-agent/blob/main/go.mod#L35.

I've tried by pinning an old container-registry, but then fails on wharfie, which requires new one:

# github.com/rancher/wharfie/pkg/registries
/go/pkg/mod/github.com/rancher/wharfie@v0.5.3/pkg/registries/registries.go:141:16: undefined: remote.DefaultTransport

Right, this was why I raised some concern on the prior PR.

[rosskirkpat]

@mudler Would you be able to raise an issue on wharfie documenting the problems we have found? It should probably be escalated to the RKE2 team as well as they are responsible for managing wharfie.

I am including my personal notes below:

system-agent is locked to 0.4.3 of wharfie due to missing methods (Resolve + RoundTrip) if bumping github.com/google/go-containerregistry above v0.5.0.
The latest wharfie is 0.5.3, which supports up to github.com/google/go-containerregistry v0.7.0

We are unable to bump gocr to latest (0.10.0) or >0.7.0 due to missing methods.

# github.com/rancher/system-agent/pkg/image
..\..\go\pkg\mod\github.com\rancher\system-agent@v0.2.9-rc1\pkg\image\util.go:98:27: cannot use registry (variable of type *registries.registry) as type authn.Keychain in array or slice literal:
        *registries.registry does not implement authn.Keychain (missing Resolve method)
..\..\go\pkg\mod\github.com\rancher\system-agent@v0.2.9-rc1\pkg\image\util.go:113:36: registry.Rewrite undefined (type *registries.registry has no field or method Rewrite)
..\..\go\pkg\mod\github.com\rancher\system-agent@v0.2.9-rc1\pkg\image\util.go:115:25: cannot use registry (variable of type *registries.registry) as type http.RoundTripper in argum
ent to remote.WithTransport:
        *registries.registry does not implement http.RoundTripper (missing RoundTrip method)