-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cacert from rancher and use serverl-url from rancher #36
Conversation
Signed-off-by: Itxaka <igarcia@suse.com>
Also drops the cacert passing via chart, adds proper permissions to the settings resource, adds the cache index and checks that indeed we are returning a cacert on the registration url Signed-off-by: Itxaka <igarcia@suse.com>
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 42.55% 41.42% -1.14%
==========================================
Files 9 9
Lines 658 676 +18
==========================================
Hits 280 280
- Misses 358 376 +18
Partials 20 20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sorry folks, Im gonna actually update this to include the server-url fix as its pretty simple and similar! |
Drop any manual setup of rancher-url and use the settings to get the set rancher-url Signed-off-by: Itxaka <igarcia@suse.com>
Signed-off-by: Itxaka <igarcia@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👌
Signed-off-by: Itxaka <igarcia@suse.com>
5c9e9eb
to
cfcd5b7
Compare
Signed-off-by: Itxaka igarcia@suse.com
Fixes #32