elemental-operator register: add elemental cli call #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The elemental-operator register command, after retrieving the config registration will directly call the elemental cli to start the actual installation process. Co-authored-by: David Cassany <dcassany@suse.com> Co-authored-by: Francesco Giudici <francesco.giudici@suse.com> Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 42.55% 42.55%
=======================================
Files 9 9
Lines 658 658
=======================================
Hits 280 280
Misses 358 358
Partials 20 20 Continue to review full report at Codecov.
|
Itxaka
reviewed
Jul 13, 2022
| if err != nil { | ||
| return err | ||
| } | ||
| install.PrintEnv(fullConf) |
There was a problem hiding this comment.
do we want to print this here?
There was a problem hiding this comment.
we just included it to ease debugging, there is quite some code to polish/remove within the repository. Not really relevant for now I'd say as this should keep changing during the following days.
Itxaka
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The elemental-operator register command, after retrieving the config
registration will directly call the elemental cli to start the actual
installation process.
Co-authored-by: David Cassany dcassany@suse.com
Co-authored-by: Francesco Giudici francesco.giudici@suse.com
Related to #7