Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MachineRegistration example #66

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

fgiudici
Copy link
Member

just update the example with the one described in PR #61

@kkaempf
Copy link
Contributor

kkaempf commented Jul 20, 2022

The write_files is still unclear to me.
We should place a README next to this file with explanations.
(or can we add comments into the file directly ? 🤩 )

Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
@fgiudici fgiudici force-pushed the update_machinereg_example branch from 14b1039 to 4aa53c9 Compare July 20, 2022 12:15
@Itxaka
Copy link
Contributor

Itxaka commented Jul 20, 2022

The write_files is still unclear to me.

what is unclear? Its a cloud config directive. Whatever is on the cloud-configkey will get dumped into a cloud-config file, so anything valid on a cloud-config file is valid in our cloud-config struct 👍 write_files is exactly: https://cloudinit.readthedocs.io/en/latest/topics/modules.html#write-files

@fgiudici
Copy link
Member Author

Well, just added the path to write_files (I didn't realized I forgot it!) and a comment to highlight what @Itxaka basically wrote here (you can put your cloud-init section of choice)

@fgiudici fgiudici merged commit 90791e4 into main Jul 20, 2022
@fgiudici fgiudici deleted the update_machinereg_example branch July 20, 2022 13:51
@kkaempf
Copy link
Contributor

kkaempf commented Jul 20, 2022

Well, just added the path to write_files

Thanks ! This is what I was missing 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants