Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the elemental-rootfs feature #1163

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Use the elemental-rootfs feature #1163

merged 2 commits into from
Jan 11, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Jan 9, 2024

The new elemental-rootfs and elemental-sysroot features are drop-in replacements for immutable-rootfs feature.

@frelon frelon force-pushed the new-rootfs branch 2 times, most recently from d00188c to 3dad119 Compare January 9, 2024 14:57
@frelon frelon marked this pull request as ready for review January 9, 2024 16:45
@frelon frelon requested a review from a team as a code owner January 9, 2024 16:45
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather see it split into two commits (or even PRs) ?

  • the "elemental-rootfs" feature
  • the rename from ".../cos/..." to ".../elemental/..."

The new elemental-rootfs and elemental-sysroot features are drop-in
replacements for immutable-rootfs feature.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.
Next time, please create separate PRs for such cases

@frelon frelon merged commit c1f29a3 into rancher:main Jan 11, 2024
3 checks passed
@frelon frelon deleted the new-rootfs branch January 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants