Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elemental-register systemd service #951

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

ldevulder
Copy link
Contributor

RemainAfterExit should be defined in Unit section.

This PR should fix this error I saw on node:
Screenshot from 2023-08-17 14-53-23

RemainAfterExit should be defined in Unit section.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
@ldevulder ldevulder added the kind/bug Something isn't working label Aug 17, 2023
@ldevulder ldevulder requested a review from a team as a code owner August 17, 2023 12:54
@ldevulder ldevulder self-assigned this Aug 17, 2023
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮
Why didn't we see this before ?!

@kkaempf kkaempf enabled auto-merge (rebase) August 17, 2023 13:08
@kkaempf kkaempf merged commit 189e20f into main Aug 17, 2023
@kkaempf kkaempf deleted the fix-elemental-register-service branch August 17, 2023 13:12
@ldevulder
Copy link
Contributor Author

Why didn't we see this before ?!

Because QA was in vacation! :D But in fact it has been added recently.

@anmazzotti
Copy link
Contributor

😮 Why didn't we see this before ?!

I tested this locally on my machine and I convinced the reviewer it would work. :(
I think I made a copy/paste error though.

I now learned how to build a local iso, so I can test the real thing next time.

@kkaempf
Copy link
Contributor

kkaempf commented Aug 17, 2023

As long as Staging isn't affected, I'm relieved 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants