Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark suite #3120

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add benchmark suite #3120

merged 1 commit into from
Jan 10, 2025

Conversation

manno
Copy link
Member

@manno manno commented Dec 4, 2024 •
edited
Loading

  • add benchmarks
  • add test data
  • experiments use group label instead of repo-name label w fleet 0.9.11
  • add toggle for metrics
  • script uses stable benchmark order via --seed
  • check for at least one cluster
  • skip confusing report table printing as we don't use sampling

TODO

@manno manno force-pushed the benchmark-suite branch 5 times, most recently from 095a595 to 674be05 Compare December 11, 2024 15:54
@manno manno marked this pull request as ready for review December 12, 2024 13:43
@manno manno requested a review from a team as a code owner December 12, 2024 13:43
@manno manno force-pushed the benchmark-suite branch 2 times, most recently from b1ab9b0 to 082b115 Compare December 13, 2024 15:08
weyfonk
weyfonk reviewed Dec 17, 2024
View reviewed changes
dev/benchmarks.sh Outdated Show resolved Hide resolved
dev/benchmarks.sh Outdated Show resolved Hide resolved
benchmarks/record/record.go Show resolved Hide resolved
benchmarks/record/record.go Show resolved Hide resolved
benchmarks/record/record.go Show resolved Hide resolved
benchmarks/report/report.go Show resolved Hide resolved
benchmarks/deploy_test.go Outdated Show resolved Hide resolved
benchmarks/deploy_test.go Outdated Show resolved Hide resolved
benchmarks/deploy_test.go Outdated Show resolved Hide resolved
benchmarks/gitrepo_bundle_test.go Outdated Show resolved Hide resolved
@kkaempf kkaempf added this to the v2.11.0 milestone Dec 19, 2024
@manno manno force-pushed the benchmark-suite branch 3 times, most recently from bc9c51f to 9c3e81a Compare January 9, 2025 14:02
@manno
Add benchmark suite
84c6211 
* add benchmarks
* add test data
* experiments use group label instead of repo-name label w fleet 0.9.11
* add toggle for metrics
* script uses stable benchmark order via --seed
* check for at least one cluster
* skip confusing report table printing as we don't use sampling
@manno manno merged commit 6d7d981 into main Jan 10, 2025
12 checks passed
@manno manno deleted the benchmark-suite branch January 10, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyfonk weyfonk weyfonk left review comments

Assignees
No one assigned
Labels
None yet
Projects
Fleet
Archived in project
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@manno @weyfonk @kkaempf