[v0.11] - Change ImageScanCommit in GitRepo spec to a pointer (#3302) #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As ImageScanCommit is an optional field inside the GitRepo spec this PR changes it to be a pointer. Not doing so means that the veru first time the `GitRepo` is stored in the cluster default values will be created and generation will be incresed, which means a double polling for the `GitRepo` when it is created. The first time the `GitRepo` is polled because the `LastPollingTime` is not set. The second time it is polled because of the generation change mentioned above. Aside from double polling in a short period of time this PR also tries to prevent an extra reconciler call that is not needed. Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
weyfonk
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As ImageScanCommit is an optional field inside the GitRepo spec this PR changes it to be a pointer.
Not doing so means that the veru first time the
GitRepois stored in the cluster default values will be created and generation will be incresed, which means a double polling for theGitRepowhen it is created.The first time the
GitRepois polled because theLastPollingTimeis not set. The second time it is polled because of the generation change mentioned above.Aside from double polling in a short period of time this PR also tries to prevent an extra reconciler call that is not needed.
Backport of #3302