Integrate Drone CI into Github Actions Workflow #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayandas
force-pushed
the
integrate-drone-ci
branch
from
0a7d5c1 to
d55c1a8
Compare
rayandas
force-pushed
the
integrate-drone-ci
branch
from
d55c1a8 to
e1485b9
Compare
rayandas
force-pushed
the
integrate-drone-ci
branch
from
3824439 to
93e1071
Compare
jiaqiluo
requested changes
Feb 17, 2022
rayandas
force-pushed
the
integrate-drone-ci
branch
from
93e1071 to
fcb6fb7
Compare
jiaqiluo
requested changes
Feb 17, 2022
rayandas
force-pushed
the
integrate-drone-ci
branch
from
fcb6fb7 to
662bee4
Compare
jiaqiluo
approved these changes
Feb 17, 2022
Merged
rayandas
added a commit
to rayandas/ingress-nginx
that referenced
this pull request
Feb 24, 2022
kinarashah
pushed a commit
to kinarashah/ingress-nginx
that referenced
this pull request
Apr 21, 2022
kinarashah
pushed a commit
to kinarashah/ingress-nginx
that referenced
this pull request
Apr 25, 2022
doflamingo721
pushed a commit
to doflamingo721/ingress-nginx
that referenced
this pull request
Jun 7, 2022
doflamingo721
pushed a commit
to doflamingo721/ingress-nginx
that referenced
this pull request
Jun 7, 2022
kinarashah
pushed a commit
to kinarashah/ingress-nginx
that referenced
this pull request
Jun 9, 2022
kinarashah
pushed a commit
to kinarashah/ingress-nginx
that referenced
this pull request
Jun 9, 2022
samkulkarni20
pushed a commit
to samkulkarni20/ingress-nginx
that referenced
this pull request
Jun 10, 2022
samkulkarni20
pushed a commit
to samkulkarni20/ingress-nginx
that referenced
this pull request
Jun 10, 2022
rayandas
added a commit
to rayandas/ingress-nginx
that referenced
this pull request
Jan 20, 2023
rayandas
added a commit
to rayandas/ingress-nginx
that referenced
this pull request
May 2, 2023
rayandas
added a commit
to rayandas/ingress-nginx
that referenced
this pull request
Aug 21, 2023
chiukapoor
pushed a commit
to chiukapoor/ingress-nginx
that referenced
this pull request
Oct 11, 2023
vardhaman22
pushed a commit
that referenced
this pull request
Nov 7, 2023
chiukapoor
pushed a commit
to chiukapoor/ingress-nginx
that referenced
this pull request
Feb 20, 2024
vardhaman22
pushed a commit
to vardhaman22/ingress-nginx
that referenced
this pull request
May 13, 2024
vardhaman22
pushed a commit
to vardhaman22/ingress-nginx
that referenced
this pull request
Jun 6, 2024
krunalhinguu
pushed a commit
that referenced
this pull request
Aug 21, 2024
remove the upstream's workflow Add arm and s390x in the arches in scripts/build. only amd64 and arm64 was in arches because of this the CI wasn't able to find the following files with not found error. /bin/arm/nginx-ingress-controller, /bin/arm/wait-shutdown and /bin/arm/dbg fix drone build failure `go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569 use rancher's repository image remove depreview action revert back PR #81 removed drone ci add drone's build and validate job in github actions workflow add release workflow which will run only while tagging added git in workflow steps for build and release remove G109 check till gosec resolves issues Remove test step from our CI Remove test step from our CI because it runs the upstream's e2e Go tests incorrectly and fails. Since we don't have any tests of our own, and upstream's CI already runs these tests, this step can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Integrate the Drone CI into upstream's Github Workflow CI so that it is just another step in their CI and everything runs as one. The building/tagging functionality of the CI should remain unchanged, it just needs to be consolidated so we don’t have 2 separate CIs.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes rancher/rancher#35246Special notes for your reviewer: