Provide helper Pod params as env vars. #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoltzsche
force-pushed
the
provide_params_as_env_vars_to_helper_pod
branch
from
1e35811
to
45b75fe
Compare
mgoltzsche
force-pushed
the
provide_params_as_env_vars_to_helper_pod
branch
2 times, most recently
from
8731622
to
6758ec6
Compare
mgoltzsche
force-pushed
the
provide_params_as_env_vars_to_helper_pod
branch
2 times, most recently
from
12dbd1f
to
5a0f570
Compare
For backward compatibility the CLI options are still provided. Closes rancher#175 Signed-off-by: Max Goltzsche <max.goltzsche@gmail.com>
mgoltzsche
force-pushed
the
provide_params_as_env_vars_to_helper_pod
branch
from
5a0f570
to
f073e86
Compare
|
@derekbit this PR is also ready for review - I just rebased it. |
|
@mgoltzsche |
|
This PR reduces the amount of redundant boilerplate code needed to configure a helper pod (the option-to-env-var mapping is the same for all Before I provide a PR for #164 I wanted to clean that up and avoid breaking helper pod configurations that eventually exist already and would fail if a new parameter would be provided that is unknown to them. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For backward compatibility the CLI options are still provided.
Closes #175
Split from PR #166