-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default volume type in storage class #311
Merged
derekbit
merged 8 commits into
rancher:master
from
js185692:storage-class-default-volume-type
Mar 22, 2023
Merged
Set default volume type in storage class #311
derekbit
merged 8 commits into
rancher:master
from
js185692:storage-class-default-volume-type
Mar 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
reviewed
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM.
Suggest having a test case.
derekbit
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Will test and merge it tomorrow.
@js185692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have many
StatefulSet
workloads requiring the provisioner to createlocal
volumes during provisioning. For several of theseStatefulSets
, we are unable to add thevolumeType
annotation which results in us having to usehostPath
volumes which is unacceptable for us. Furthermore, it is tedious and error-prone to have to specify thevolumeType
annotation on every single PVC and would therefore prove useful to be able to specify a default volume type on theStorageClass
.I propose the addition of an annotation called
defaultVolumeType
on storage classes which will set the volume type for all volumes using that class. The annotation for the PVC can still be applied and will supersede the annotation on the storage class.A basic example of a
StorageClass
with this annotation: