Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: pvs not deleting was: Remove the assumption that a node's name == its hostname #414

Merged
merged 2 commits into from
Aug 31, 2024

Commits on Jun 7, 2024

  1. Remove the assumption that a node's name == its hostname

    As per https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#built-in-node-labels
    [[[
    Note:
    The value of these labels is cloud provider specific and is not guaranteed to be reliable. For example, the value of kubernetes.io/hostname may be the same as the node name in some environments and a different value in other environments.
    ]]]
    jan-g committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    cc0d387 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. e2e: confirm the cleanup of PVs with legacy affinity attributes

    This applies a small refactor to the e2e tests to ensure that the newer
    provisioner is capable of siting helper pods correctly to clean up PVs
    with "legacy" affinity constraints.
    
    The kind cluster itself is reconfigured to ensure that all nodes have
    `metadata.name` != `metadata.labels["kubernetes.io/hostname"]`, which is
    an assumption that does not hold for many cloud providers.
    jan-g committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    199ec0a View commit details
    Browse the repository at this point in the history