Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: wait for the provisioner to clean up PV resources #416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jan-g
Copy link
Contributor

@jan-g jan-g commented Jun 7, 2024

If we're unlucky, the local-path-provisioner can be killed before it has a chance to clean up orphened PVs. These may then hang around while subsequent tests run. Depending on the lexical sort order of those PVs, the typeCheckCmd in runTest may select a moribund PV, causing the test to randomly fail.

If we're unlucky, the local-path-provisioner can be killed before it has a chance
to clean up orphened PVs. These may then hang around while subsequent tests run.
Depending on the lexical sort order of those PVs, the `typeCheckCmd` in `runTest`
may select a moribund PV, causing the test to randomly fail.
@derekbit
Copy link
Member

The flaky failure condition seems related the cleanup order of the storageclass.

@jan-g
Copy link
Contributor Author

jan-g commented Jun 14, 2024

It's just passing the output of kustomize into kubectl delete. Every kustomize call is (re)installing the storageclass helper.

This PR explicitly tags the storageclass stuff so that kubectl delete has a label to only ditch the pod & pvc before it waits on the cleanup completing.

@jan-g
Copy link
Contributor Author

jan-g commented Jul 15, 2024

@derekbit is there more required to progress this?

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Aug 30, 2024
@derekbit derekbit removed the stale label Aug 30, 2024
@jan-g
Copy link
Contributor Author

jan-g commented Aug 31, 2024

@derekbit I cannot merge this - can you do the honours please?

@derekbit
Copy link
Member

@derekbit I cannot merge this - can you do the honours please?

Sure. I'm reviewing it. No worries. Will merger it if there is no concern. Thanks you.

@derekbit
Copy link
Member

@jan-g Could you resolve the conflicts? Thank you.

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can merge it before resolving the conflicts.

@derekbit derekbit self-requested a review September 1, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants