Upgrade sig storage lib external provisioner #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass locally with |
Thanks @rorosen |
derekbit
force-pushed
the
upgrade-sig-storage-lib-external-provisioner
branch
from
e77a6d9
to
8f134a3
Compare
This also requires to update the minimun go version from 1.21 to 1.22.0, as sig-storage-lib-external-provisioner requires at least go 1.22.0. Additionally, sig-storage-lib-external-provisioner now uses patch to modify finalizers on PersistentVolumes, meaning that external provisioners now need permission rules to patch PersistentVolumes. https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/releases/tag/v10.0.0 https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/releases/tag/v10.0.1 Signed-off-by: Robert Rose <robert.rose@mailbox.org>
Signed-off-by: Derek Su <derek.su@suse.com>
derekbit
force-pushed
the
upgrade-sig-storage-lib-external-provisioner
branch
from
8f134a3
to
afbdd4b
Compare
derekbit
approved these changes
Aug 30, 2024
|
Thanks for the contribution @rorosen. |
lumiere-bot bot
added a commit
to coolguy1771/home-ops
that referenced
this pull request
Sep 3, 2024
…9 ) (#5335) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [local-path-provisioner](https://redirect.github.com/rancher/local-path-provisioner) | patch | `v0.0.28` -> `v0.0.29` | --- ### Release Notes <details> <summary>rancher/local-path-provisioner (local-path-provisioner)</summary> ### [`v0.0.29`](https://redirect.github.com/rancher/local-path-provisioner/releases/tag/v0.0.29): Local Path Provisioner v0.0.29 [Compare Source](https://redirect.github.com/rancher/local-path-provisioner/compare/v0.0.28...v0.0.29) #### What's Changed - Update Go to 1.22.5 by [@​unguiculus](https://redirect.github.com/unguiculus) in [rancher/local-path-provisioner#435 - vendor: update dependencies by [@​derekbit](https://redirect.github.com/derekbit) in [rancher/local-path-provisioner#446 - Upgrade sig storage lib external provisioner by [@​rorosen](https://redirect.github.com/rorosen) in [rancher/local-path-provisioner#445 - chore(workflow): add "Scan With Trivy and Upload Results to GitHub Security Tab" by [@​derekbit](https://redirect.github.com/derekbit) in [rancher/local-path-provisioner#448 - Bugfix: pvs not deleting was: Remove the assumption that a node's name == its hostname by [@​jan-g](https://redirect.github.com/jan-g) in [rancher/local-path-provisioner#414 - Bump to v0.0.29 by [@​derekbit](https://redirect.github.com/derekbit) in [rancher/local-path-provisioner#450 #### Contributors - [@​unguiculus](https://redirect.github.com/unguiculus) - [@​galal-hussein](https://redirect.github.com/galal-hussein) - [@​jamshidi799](https://redirect.github.com/jamshidi799) - [@​rorosen](https://redirect.github.com/rorosen) - [@​jan-g](https://redirect.github.com/jan-g) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC42NC4yIiwidXBkYXRlZEluVmVyIjoiMzguNjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvZ2l0aHViLXJlbGVhc2UiLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot
added a commit
to coolguy1771/home-ops
that referenced
this pull request
Sep 3, 2024
…9 ) (#5334) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [local-path-provisioner](https://redirect.github.com/rancher/local-path-provisioner) | patch | `v0.0.28` -> `v0.0.29` | --- ### Release Notes <details> <summary>rancher/local-path-provisioner (local-path-provisioner)</summary> ### [`v0.0.29`](https://redirect.github.com/rancher/local-path-provisioner/releases/tag/v0.0.29): Local Path Provisioner v0.0.29 [Compare Source](https://redirect.github.com/rancher/local-path-provisioner/compare/v0.0.28...v0.0.29) #### What's Changed - Update Go to 1.22.5 by [@​unguiculus](https://redirect.github.com/unguiculus) in [rancher/local-path-provisioner#435 - vendor: update dependencies by [@​derekbit](https://redirect.github.com/derekbit) in [rancher/local-path-provisioner#446 - Upgrade sig storage lib external provisioner by [@​rorosen](https://redirect.github.com/rorosen) in [rancher/local-path-provisioner#445 - chore(workflow): add "Scan With Trivy and Upload Results to GitHub Security Tab" by [@​derekbit](https://redirect.github.com/derekbit) in [rancher/local-path-provisioner#448 - Bugfix: pvs not deleting was: Remove the assumption that a node's name == its hostname by [@​jan-g](https://redirect.github.com/jan-g) in [rancher/local-path-provisioner#414 - Bump to v0.0.29 by [@​derekbit](https://redirect.github.com/derekbit) in [rancher/local-path-provisioner#450 #### Contributors - [@​unguiculus](https://redirect.github.com/unguiculus) - [@​galal-hussein](https://redirect.github.com/galal-hussein) - [@​jamshidi799](https://redirect.github.com/jamshidi799) - [@​rorosen](https://redirect.github.com/rorosen) - [@​jan-g](https://redirect.github.com/jan-g) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC42NC4yIiwidXBkYXRlZEluVmVyIjoiMzguNjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvZ2l0aHViLXJlbGVhc2UiLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also requires to update the minimun go version from 1.21 to 1.22.,
as sig-storage-lib-external-provisioner requires at least go 1.22.0.
Additionally, sig-storage-lib-external-provisioner now uses patch
to modify finalizers on PersistentVolumes, meaning that external
provisioners now need permission rules to patch PersistentVolumes.
The permission is already present in deploy/local-path-storage.yaml.
https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/releases/tag/v10.0.0
https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/releases/tag/v10.0.1
Steps executed:
sig-storage-lib-external-provisioner/v10 v10.0.1go mod tidygo mod vendorFixes #179.