This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
running Kompose from source #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prachidamle
force-pushed
the
run_kompose_frm_src
branch
from
97f21a8 to
85119ef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alena1108 can you merge this :)
We had to remove trash and use glide for this project to manage vendor dependencies.
Reason is the case collision for imports to github.com/sirupsen/logrus repo
refer: sirupsen/logrus#543
Solution is sirupsen/logrus#553 (comment)
Crux of the issue is: Kompose depends on Openshift/origin project which depends on an old commit of docker/distribution repo that refers to uppercase https://github.com/Sirupsen/logrus.
Updating to the latest docker/distribution repo (that has fixes to use lowercase sirupsen/logrus) does not help as the Openshift/origin project uses code that got removed in latest docker/distribution commits.