Skip to content

Commit

Permalink
Allow namespaces to have finalizers
Browse files Browse the repository at this point in the history
Now the we are properly formatting finalizer names, they can
successfully be added to namespaces. This has is no longer needed.
  • Loading branch information
Craig Jellick committed Jan 15, 2018
1 parent faf2f35 commit a26be15
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions lifecycle/object.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,6 @@ func (o *objectLifecycleAdapter) addFinalizer(obj runtime.Object) (runtime.Objec
return nil, err
}

if o.objectClient.GroupVersionKind().Kind == "Namespace" {
return obj, nil
}

if slice.ContainsString(metadata.GetFinalizers(), o.constructFinalizerKey()) {
return obj, nil
}
Expand Down

0 comments on commit a26be15

Please sign in to comment.