Support parsing the body of actions #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 14, 2018 18:57
Previously we were passing the name of the field, not the type
PostForm will ignore URL query parameters and will only look at the body. This is much more useful for actions, which have a query param that is the action name, but the a json body. WIthout this change, the only "field" found when parsing an action body is the name of the action.
|
Got a "seems reasonable" from @ibuildthecloud offline |
jordanjean
pushed a commit
to jordanjean/norman
that referenced
this pull request
Jan 7, 2020
Fix: don't delete builtin cluster nor node drivers from rancher on tf destroy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.